From: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
Date: Tue, 31 Jul 2018 16:23:05 +0000 (-0300)
Subject: system: Don't execute Settings
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~929^2~4^2~11
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f433b12d6e7110031a46f74b83d3318b1f242fd8;p=gnome-shell.git

system: Don't execute Settings

In a9ad91c831, a bug was introduced in the following code:

```c
            this._settingsAction.connect('clicked',
                                         this._onSettingsClicked().bind(this));
```

Notice that the callback is being executed! This commit
fixes that by removing the '()' from the callback.
---

diff --git a/js/ui/status/system.js b/js/ui/status/system.js
index 81b985c1f..c695f37be 100644
--- a/js/ui/status/system.js
+++ b/js/ui/status/system.js
@@ -269,7 +269,7 @@ var Indicator = new Lang.Class({
                                 app.get_name()];
             this._settingsAction = this._createActionButton(icon, name);
             this._settingsAction.connect('clicked',
-                                         this._onSettingsClicked().bind(this));
+                                         this._onSettingsClicked.bind(this));
         } else {
             log('Missing required core component Settings, expect trouble…');
             this._settingsAction = new St.Widget();